fix(legacy prefix detection): calculate range end for legacy prefix instead of empty #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of empty Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
force-pushed
the
fix_legacy_prefix
branch
from
c7c58c3
to
528a02f
Compare
|
bors try |
tiagolobocastro
approved these changes
Feb 26, 2024
tryBuild succeeded: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
761: fix(legacy prefix detection): calculate range end for legacy prefix instead of empty r=Abhinandan-Purkait a=Abhinandan-Purkait #### What is the issue? For legacy prefix detection we used the paginated call with range end as `""`, which was incorrect as `""` range end fetches all the values, irrespective of the key prefix. Now we calculate the range end with legacy prefix thus we get only the specific KVs. Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
762: fix(legacy prefix detection): calculate range end for legacy prefix instead of empty r=Abhinandan-Purkait a=Abhinandan-Purkait Cherry pick #761 Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue?
For legacy prefix detection we used the paginated call with range end as
"", which was incorrect as""range end fetches all the values, irrespective of the key prefix. Now we calculate the range end with legacy prefix thus we get only the specific KVs.